ffmpeg removing nv headers ?

Questions that occur when trying to compile FFmpeg.
Post Reply
hydra3333
Posts: 198
Joined: Sun Apr 28, 2013 1:03 pm
Contact:

ffmpeg removing nv headers ?

Post by hydra3333 » Wed Feb 28, 2018 2:41 pm

Seeking advice, I'm out of my depth in figuring out what they're trying to say/do ...

this patch seems to be removing headers to do with NV stuff https://patchwork.ffmpeg.org/patch/7735/
From: Timo Rothenpieler <[email protected]>

External headers are no longer welcome in the ffmpeg codebase because they
increase the maintenance burden. However, in the NVidia case the vanilla
headers need some modifications to be usable in ffmpeg therefore we still
provide them, but in a separate repository.

The external headers can be found at
https://git.videolan.org/?p=ffmpeg/nv-codec-headers.git

This patch squashes Timo's patches from Dec 4 last year, and also removes most
part of compat/dynlink_loader.h because that was added to the headers repo as
well.

Fate-source is updated because of the deleted files, and dynlink_loader.h
license headers were updated with the standard FFmpeg headers.

Only compile tested and only on Linux.
I wonder, like jb does here https://github.com/jb-alvarado/media-au ... t-27827282 does this now mean for cross-compiling per rdp's script, that we need to also "install" it before one can build ffmpeg with the NV/CUDA switches on the commandline to get it baked into ffmpeg ?, eg before one can use the ffmpeg configure switches

Code: Select all

--enable-nvenc --enable-cuda --enable-cuvid 

hydra3333
Posts: 198
Joined: Sun Apr 28, 2013 1:03 pm
Contact:

Re: ffmpeg removing nv headers ?

Post by hydra3333 » Thu Mar 01, 2018 5:04 am

Yes it does, something like per this
https://github.com/DeadSix27/python_cro ... -369257813 thanks to deadsix27 and rdp.

eg hacked up for an rdp-based script:

Code: Select all

build_nv_headers() {
echo "---------------------------------------------------------------------------------------------------"
echo "---------------------------------------------------------------------------------------------------"
echo "build_nv_headers \"${1}\""
echo "---------------------------------------------------------------------------------------------------"
echo "---------------------------------------------------------------------------------------------------"
  # 2018.02.28 - ffmpeg now requires these headers from another repo per 
  # https://github.com/DeadSix27/python_cross_compile_script/issues/43
  # https://github.com/DeadSix27/python_cross_compile_script/commit/3dd2de00545d84aa711b5df133b07b55e7bbeca5#diff-e223906984ace16458e9ef6f3437aeeeR3420
  # https://github.com/jb-alvarado/media-autobuild_suite/commit/42df66ae62db312d854e1e2b94e6f8223440a7e6#commitcomment-27827282
  do_git_checkout https://git.videolan.org/git/ffmpeg/nv-codec-headers.git nv-codec-headers_git
  cd nv-codec-headers_git
    make all PREFIX=${mingw_w64_x86_64_prefix}
    make install all PREFIX=${mingw_w64_x86_64_prefix}
  cd ..
  #read -p "After build_nv_headers for bits_target=${bits_target} with_bitdepth=${with_bitdepth} ... Press Enter to continue... or control-C if not happy"
}
One assumes zeranoe has picked up on it and incorporated the necessary mod into the nightly builds.

hydra3333
Posts: 198
Joined: Sun Apr 28, 2013 1:03 pm
Contact:

[FFmpeg-devel] [PATCH] configure: rename cuda to ffnvcodec

Post by hydra3333 » Sun Mar 04, 2018 1:29 am

I see this may also change ...

[FFmpeg-devel] [PATCH] configure: rename cuda to ffnvcodec
http://ffmpeg.org/pipermail/ffmpeg-deve ... 26039.html

just a thought, configure would need to be updated when that's implemented

Post Reply