Support for external libfaac would be nice.

Any suggestions that you have about the builds.

Support for external libfaac would be nice.

Postby Selur » Thu Jul 07, 2011 7:56 am

Would be nice if the ffmpeg builds would support libfaac as external library.

Cu Selur
Selur
 
Posts: 24
Joined: Thu Jul 07, 2011 7:52 am

Re: Support for external libfaac would be nice.

Postby Zeranoe » Thu Jul 07, 2011 6:10 pm

If I built FFmpeg with FAAC the builds would not be redistributable.
User avatar
Zeranoe
Site Admin
 
Posts: 545
Joined: Sat May 07, 2011 7:12 pm

Re: Support for external libfaac would be nice.

Postby Selur » Sat Jul 09, 2011 10:07 am

Oh, I thought it would be okay, since Sherpya's builds don't include libfaac but support it as an external library, see: http://oss.netfarm.it/mplayer-win32.php

Cu Selur
Selur
 
Posts: 24
Joined: Thu Jul 07, 2011 7:52 am

Re: Support for external libfaac would be nice.

Postby Zeranoe » Sat Jul 09, 2011 11:06 am

Please note that "--enable-libfaac" is in "Sherpya" build configure.

That flag alone will force FFmpeg to be "non free" so they either edited the source and didn't include the patch, or something else is going on.

I downloaded one of there builds and it's didn't seem to work, it also suppressed all output.

EDIT: I had to redirect the output to even see any output from that FFmpeg.

It is enabled with FAAC support, while enabling the support is not strictly against the GPL (I don't believe) it's riding a thin line. Editing of the source must have taken place to ignore faac dependencies to allow for a build, or FAAC is actually within the binary which breaks GPL, and I see no patch which does break the GPL.

The source for that version was included, but the patch is not (I believe you need both for follow GPL).

I don't despise FAAC or anything, and to include a feature that looks for FAAC within the directory wouldn't be a bad idea, without actually building FAAC into the binary at all.

Feel free to submit this idea to the mailing list/irc.
User avatar
Zeranoe
Site Admin
 
Posts: 545
Joined: Sat May 07, 2011 7:12 pm

Re: Support for external libfaac would be nice.

Postby Selur » Sat Jul 09, 2011 11:11 am

Yup, last ffmpeg build is borked,.. the one before that should work,..
Selur
 
Posts: 24
Joined: Thu Jul 07, 2011 7:52 am

Re: Support for external libfaac would be nice.

Postby Zeranoe » Sat Jul 09, 2011 11:16 am

I edited my previous post, please read it for further updates.
User avatar
Zeranoe
Site Admin
 
Posts: 545
Joined: Sat May 07, 2011 7:12 pm

Re: Support for external libfaac would be nice.

Postby Selur » Sat Jul 09, 2011 11:20 am

Okay. Thanks for looking at it. :)
Selur
 
Posts: 24
Joined: Thu Jul 07, 2011 7:52 am

Re: Support for external libfaac would be nice.

Postby ramiro » Sat Jul 09, 2011 7:26 pm

it is a very thin line and official ffmpeg stance before the split was that they didn't like it.
sherpya doesn't seem to care though.
ramiro
 
Posts: 153
Joined: Tue May 10, 2011 12:56 am

Re: Support for external libfaac would be nice.

Postby rogerdpack » Fri Jun 22, 2012 6:30 pm

https://github.com/sherpya/FFmpeg/commi ... b69d6159f3

appears to be his dynload faac patch
rogerdpack
 
Posts: 1454
Joined: Fri Aug 05, 2011 9:56 pm

Re: Support for external libfaac would be nice.

Postby AmshTemp » Thu Jul 12, 2012 10:19 pm

Great news: Libav have just added support for libfdk-aac. FFmpeg will follow soon.

In case you don't know libfdk-aac; It is a *very* high quality *commercial* aac encoder made by the Fraunhofer, and just been opensouced by Google with the release of Android jelly bean v4.1
http://opencore-amr.git.sourceforge.net ... -index.cgi

There are no longer any need for inferior aac encoders like FFmpeg, VisualOn and LibFAAC.

Now waiting for that new ffmpeg build featuring libfdk-aac.......
AmshTemp
 
Posts: 2
Joined: Fri Sep 16, 2011 1:51 pm

Next

Return to Builds Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest